Re: [PORTS] Re: patch for minor Win32 makefile bug - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: [PORTS] Re: patch for minor Win32 makefile bug
Date
Msg-id Pine.LNX.4.30.0104042241030.1378-100000@peter.localdomain
Whole thread Raw
In response to Re: [PORTS] Re: patch for minor Win32 makefile bug  (Jason Tishler <Jason.Tishler@dothill.com>)
Responses Re: [PORTS] Re: patch for minor Win32 makefile bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Jason Tishler writes:

> See attached for the updated patch.

It seems we're now down to

DLLLIBS= -lcygipc -lcrypt

but I think it can be removed completely.

We have three uses of this variable:

1) Makefile.win, for building extension modules.  No module in existance
needs -lcygipc, and if one needs -lcrypt it can put it into SHLIB_LINK.

2) Makefile.shlib, see 1)

3) -lcrypt already comes in via LIBS (like all the other libraries),
-lcygipc can do the same, or be hard-coded in place.

The idea behind naming a variable DLLLIBS seems to have been "libraries
necessary to create a DLL".  But ISTM that there are no such libraries,
strictly speaking.

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Next
From: Tom Lane
Date:
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug