Richard T. Robino writes:
> - A more specific postmaster startup for a normal make check which says
> whether inet or unix sockets will be used. If you aren't aware of the
> problem on solaris and don't check netstat, the message is generic and there
> is a socket file in /tmp regardless of what type of socket gets used. Kind
> of subtle.
Can be done. I guess the TCP vs Unix domain issue was never this
important before. The difference is also that the "installcheck" mode can
be used against either kind of socket using the standard --host and --port
options, depending on the requirements of the running server, whereas the
temp install mode handles this issue internally -- and it never used to
make a difference.
> - Maybe consistency in the script itself. Judging by the different styles of
> testing and the output between the --temp-install conditions, it appears as
> if each section was written by two different people. It could be cleaned up
> pretty fast and quite safely.
Although large portions of actual code were copied over from the two
separate predecessors to this script, the conventions and formatting
should tend to be fairly consistent. Just taking a quick glance now, I
would probably still write it this way, although some ideas for cosmetic
changes, such as the one above, may arise through actual use.
> Not anything that important, but in the interest of making things easier to
> understand these changes could be helpful (IMO). At the very least a mention
> of the socket thing in regress/README or the Solaris FAQ would be handy. I'd
> be happy to do any of the above if you think they are good ideas. If you're
> already on it, nevermind and thank you.
Unless we decide on any code measures, it will end up being documented in
FAQ_Solaris.
--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
