Re: /contrib 'cosmetic' - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: /contrib 'cosmetic'
Date
Msg-id Pine.LNX.4.30.0103191744500.1131-100000@peter.localdomain
Whole thread Raw
In response to /contrib 'cosmetic'  (Karel Zak <zakkr@zf.jcu.cz>)
List pgsql-hackers
Karel Zak writes:

>  - everything in the contrib tree has 'uninstall', with the
>    exception contrib/rserv

Feel free to implement it.  ;-)

>  - every "WANTED_DIRS" has Makefile and is possible install it,
>    What contrib/start-scripts, contrib/tools and contrib/retep are?

retep is installed via build.xml when you install the jdbc driver.
start-scripts needs to be installed manually anway.  'tools' doesn't need
to be installed because they are source tools.

>    I mean user after 'make install' look at $(libdir)/contrib and not
>    walk in sources and search what is/isn't installed...

I don't think the contrib/Makefile is to be relied on except for cleaning.

>  In future ... please ignore patches those ignore the /contrib's practice
> -- the trouble is overhaul the contrib tree during each version.

The reason it's in contrib is that it's a bit less than perfect.  If we
were to prioritize on maintaining contrib, then we might as well fold it
into the core (which we ought to consider for some items).  IMHO.

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/



pgsql-hackers by date:

Previous
From: Jean-Michel POURE
Date:
Subject: Do you plan an RPM release of beta 6
Next
From: Martin Renters
Date:
Subject: Re: beta6 pg_restore core dumps