Re: Proposed GUC Variable - Mailing list pgsql-hackers

From Gavin Sherry
Subject Re: Proposed GUC Variable
Date
Msg-id Pine.LNX.4.21.0209010221010.18259-101000@linuxworld.com.au
Whole thread Raw
In response to Re: Proposed GUC Variable  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Proposed GUC Variable
List pgsql-hackers
On Thu, 29 Aug 2002, Tom Lane wrote:

> Gavin Sherry <swm@linuxworld.com.au> writes:
> > That's a pretty good idea. Now, what format will the argument take: text
> > (NOTICE, ERROR, DEBUG, etc) or integer? The increasing severity is clear
> > with numbers but the correlation to NOTICE, ERROR etc is undocumented
> > IIRC. On the other hand, the textual form is clear but INFO < NOTICE <
> > WARNING < ERROR < FATAL, etc, is note necessarily obvious.
>
> The variable should take the same values as SERVER_MIN_MESSAGES and
> impose the same priority order as it does.  I would assume you could
> share code, or at worst copy-and-paste a few dozen lines.

A patch implementing this is attached. Instead of copy-and-pasting the
code, I abstracted out of the lookup and converted the existing functions
to use it.

I was careful in elog() to ignore elog(LOG) calls when
log_min_error_query >= LOG.

Gavin

Attachment

pgsql-hackers by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: Re: [INTERFACES] pgaccess - where to store the own data
Next
From: "Iavor Raytchev"
Date:
Subject: pgaccess 0.98.8 beta 1 - the show starts