Re: AW: Re: GiST for 7.1 !! - Mailing list pgsql-hackers

On Thu, 11 Jan 2001, The Hermit Hacker wrote:

> On Fri, 12 Jan 2001, Oleg Bartunov wrote:
>
> > On Thu, 11 Jan 2001, The Hermit Hacker wrote:
> >
> > >
> > > just downloaded it and can't find any regression tests ... ?
> >
> > it's in the contrib-intarray.tar.gz
> > gmake, gmake install, gmake installcheck
>
> erk, can we get this somehow done in such a way that its part of the
> *standard* regression tests?  so when ppl do 'make test', the GiST stuff
> is checked also?  My worry, as with others, isn't that GiST itself is
> broken by the changes, its that *somehow* there is an interaction that is
> with the rest of the system that isn't being tested ...

No way, we need to load functions. there are several contributions
which depends on loaded functions. If you suggest how to do this
in general way, it would fine. To test GiST you need to define some
data structure ( in our case - RD-tree) and functions to access it

>
>
>
>  >
> >
> >     Oleg
> > >
> > > On Thu, 11 Jan 2001, The Hermit Hacker wrote:
> > >
> > > > On Fri, 12 Jan 2001, Oleg Bartunov wrote:
> > > >
> > > > > On Thu, 11 Jan 2001, Tom Lane wrote:
> > > > >
> > > > > > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > > > > > I understand Tom's arguments and respect his experience, so I think it's
> > > > > > > possible to put link to my page in 7.1 docs for people interested in
> > > > > > > GiST features.
> > > > > >
> > > > > > Bear in mind that I only have one core vote ;-).  We've already had some
> > > > > > private core discussion about whether to accept this patch now, and so
> > > > > > far I think I'm outvoted.
> > > > > >
> > > > >
> > > > > There are several Tom Lane, judge by your activity. You probably need
> > > > > several votes.
> > > > >
> > > > > > Did I understand you to say that you'd added some regression tests for
> > > > > > GiST?  That would lessen my unhappiness a little bit ...
> > > > >
> > > > > Yes, we did. Currently all files are available from my page
> > > > > http://www.sai.msu.su/~megera/postgres/gist/
> > > > > I could submit them to hackers list if CORE people got consensus
> > > >
> > > > Okay, if there are appropriate regression tests, I'm going to say go for
> > > > it ...
> > > >
> > > > Does anyone have any objections to my downloading the tar file (doing that
> > > > now), committing the changes and wrapping up a quick Beta4 just so that we
> > > > have a tar ball that is testable right away?
> > > >
> > > > Save Lamar and the other packagers a bit of work by avoiding beta3
> > > > packages :)
> > > >
> > > >
> > > >
> > > >
> > >
> > > Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> > > Systems Administrator @ hub.org
> > > primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
> > >
> >
> >     Regards,
> >         Oleg
> > _____________________________________________________________
> > Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
> > Sternberg Astronomical Institute, Moscow University (Russia)
> > Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
> > phone: +007(095)939-16-83, +007(095)939-23-83
> >
> >
>
> Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> Systems Administrator @ hub.org
> primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
>
Regards,    Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83