On Sun, 24 Sep 2006, Jeremy Drake wrote:
> On Thu, 21 Sep 2006, Tom Lane wrote:
>
> > I suggest that instead of testing the server-side lo_import/lo_export
> > functions, perhaps you could test the psql equivalents and write and
> > read a file in psql's working directory.
>
> I did not see any precedent for that when I was looking around in the
> existing tests for an example of how to do things.
<snip>
> When I was looking at the copy tests, it looked like the server-side ones
> were tested, and then the psql ones were tested by exporting and then
> importing data which was originally loaded from the server-side method.
I just went back and looked at the tests again. The only time the psql
\copy command was used was in the (quite recent IIRC) copyselect test, and
then only via stdout (never referring to psql working directory, or to
files at all). Did I misunderstand, and you are proposing a completely
new way of doing things in the regression tests? I am not particularly
fond of the sed substitution stuff myself, but it seems to be the only
currently supported/used method in the regression tests... I do think
that making the large object test and the copy test consistent would make
a lot of sense, since as I said before, the functionality of file access
is so similar...
--
We demand rigidly defined areas of doubt and uncertainty!
-- Vroomfondel
