Re: funny (cache (?)) bug in postgres (7.x tested) - Mailing list pgsql-hackers

From Alex Pilosov
Subject Re: funny (cache (?)) bug in postgres (7.x tested)
Date
Msg-id Pine.BSO.4.10.10107031625150.18587-100000@spider.pilosoft.com
Whole thread Raw
In response to funny (cache (?)) bug in postgres (7.x tested)  (RISKO Gergely <risko@atom.hu>)
List pgsql-hackers
On Thu, 28 Jun 2001, RISKO Gergely wrote:

> text *hupper (text *a) {
>     int hossz,i;
> 
>     hossz=a->vl_len;
>     for (i=0;i<hossz;i++)
>     {
>         char ch;
>         ch=a->vl_dat[i];
>         if ((ch>=97)&(ch<=122)) ch=ch-32;
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         else if (ch=='�') ch='�';
>         a->vl_dat[i]=ch;
>     }
> 
>     return a;
> }
(Rest snipped).

You are not supposed to write directly to the argument you are given. You
must construct a new text value (by allocating space via palloc) and
copy your string there. By overwriting existing values, you potentially
corrupt postgres' cache, resulting in your behaviour.



pgsql-hackers by date:

Previous
From: ncm@zembu.com (Nathan Myers)
Date:
Subject: Re: Re: Backup and Recovery
Next
From: "Dmitry G. Mastrukov"
Date:
Subject: Re: Re: New data type: uniqueidentifier