RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL - Mailing list pgsql-hackers

From shiy.fnst@fujitsu.com
Subject RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date
Msg-id OSZPR01MB63103CE46A7A7C177509C68FFD869@OSZPR01MB6310.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  (Önder Kalacı <onderkalaci@gmail.com>)
Responses Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
List pgsql-hackers
On Tuesday, March 21, 2023 8:03 PM Önder Kalacı <onderkalaci@gmail.com> wrote:
> 
> Attached patches again.
> 

Thanks for updating the patch.

@@ -408,15 +412,18 @@ $node_subscriber->wait_for_subscription_sync;
 $node_publisher->safe_psql(
     'postgres', qq(
         ALTER TABLE dropped_cols DROP COLUMN b_drop;
+        ALTER TABLE generated_cols DROP COLUMN c_drop;
 ));
 $node_subscriber->safe_psql(
     'postgres', qq(
         ALTER TABLE dropped_cols DROP COLUMN b_drop;
+        ALTER TABLE generated_cols DROP COLUMN c_drop;
 ));

Is there any reasons why we drop column here? Dropped column case has been
tested on table dropped_cols. The generated column problem can be detected
without dropping columns on my machine.

Regards,
Shi Yu

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Show various offset arrays for heap WAL records
Next
From: Justin Pryzby
Date:
Subject: Re: Improve logging when using Huge Pages