Request a Demo
Home   >   mailing lists

RE: Two issues with version checks in CREATE SUBSCRIPTION - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Two issues with version checks in CREATE SUBSCRIPTION
Date
Msg-id OSCPR01MB14966BDE9419034B4BE782B27F5B5A@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Two issues with version checks in CREATE SUBSCRIPTION  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Two issues with version checks in CREATE SUBSCRIPTION
List pgsql-hackers
Tree view 
Dear Fujii-san,

Thanks for the patch! They basically look good to me.

> First, in subscriptioncmds.c this check rejects enabling retain_dead_tuples
> when the publisher is running an older version. However, the comparison uses
> 19000 as v19 value. Since server versions are encoded as 190000 for v19,
> this appears to be a typo and allows the option to be enabled unexpectedly
> on pre-v19 publishers. The attached 0001 patch fixes this by correcting
> the version constant.

One idea is to introduce a constant like RETAIN_DEAD_TUPLES_MIN_VERSION_NUM,
which avoids similar typo. Is it overengineering?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication