RE: pg_createsubscriber --dry-run logging concerns - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: pg_createsubscriber --dry-run logging concerns
Date
Msg-id OSCPR01MB149668DD062C1457FFAA44A28F5E6A@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to pg_createsubscriber --dry-run logging concerns  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: pg_createsubscriber --dry-run logging concerns
List pgsql-hackers
Dear Peter,

> IMO, it's not good to fool people into thinking something has happened
> when in fact nothing happened at all. I think the logging of this tool
> should be much more explicit wrt when it is/isn't in dry-run mode.
> Perhaps like this:
> 
> NORMAL
> pg_log_info("creating publication \"%s\" in database \"%s\"", ...)
> 
> DRY-RUN
> pg_log_info("[dry-run] would create publication \"%s\" in database \"%s\"", ...)

Per my understanding, almost all the output must be adjusted based on the mode, right?
I feel it introduces a burden.
Can we solve the issue if we print additional message at the beginning if the
command runs with dry-run mode?

Best regards,
Hayato Kuroda
FUJITSU LIMITED 


pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Add tests for Bitmapset