RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Date
Msg-id OSCPR01MB1496668F87FB97A0CCB63918CF575A@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to [PATCH] Proposal: Improvements to PDF stylesheet and table column widths  (Noboru Saito <noborusai@gmail.com>)
Responses Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
List pgsql-hackers
Dear Saito-san,

> Yes, your understanding is correct. The top-right image was generated
> with the previous patch, and the bottom-right with the v2 patch.
> 
> Thank you also for your advice regarding splitting the patch into two parts:
> - 0001: Set both body.start.indent and body.end.indent to 0
> - 0002: Set margin-left and margin-right to 0.25in
> 
> I agree that separating the patches will make the review process easier.
> I will prepare and send a patch series using `git format-patch` as you
> suggested.
> 
> I have also attached a part of the PDF generated with both 0001 and
> 0002 applied for your reference.

The patch is cleanly created, and +1 for all contents.



Another general suggestion: Please avoid the top-post when you reply. According
to the wikipage [1]:

```
Finally, our community generally does not "top post" in response to mailing list threads (See Wikipedia:
Top Postingfor a definition of top posting, and Top Posting Deprecated for discussion of why we discourage it).
```

And a Japanese article written by Fujii-san is also helpful [2].

[1]: https://wiki.postgresql.org/wiki/Mailing_Lists
[2]: https://www.slideshare.net/slideshow/postgresql-community-development-deim2024-nttdata/266677773#24

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Next
From: Shinya Kato
Date:
Subject: Re: Add log_autovacuum_{vacuum|analyze}_min_duration