RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled
Date
Msg-id OSBPR01MB2552E50362BAE4857B05F25CF5EC2@OSBPR01MB2552.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled
List pgsql-hackers
Dear Amit, Ian,

> I guess it could be more work if we want to enhance the test for
> ERRORs other than the primary key violation. One simple fix is to
> update the log_offset to the location of the LOG after successful
> replication of un-conflicted data. For example, the Log location after
> we execute the below line in the test:
> 
> # Check replicated data
>                my $res =
>                  $node_subscriber->safe_psql('postgres', "SELECT
> count(*) FROM tbl");
>                is($res, $expected, $msg);

I made a patch for confirmation purpose. This worked well on my environment.
Ian, how about you?

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/ 


Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Postgres and --config-file option
Next
From: Robert Haas
Date:
Subject: Re: libpq compression (part 3)