RE: Re-read subscription state after lock in AlterSubscription - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Re-read subscription state after lock in AlterSubscription
Date
Msg-id OS9PR01MB121496CC9813CBE8C2AB20764F5F12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Whole thread
In response to Re: Re-read subscription state after lock in AlterSubscription  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Re-read subscription state after lock in AlterSubscription
List pgsql-hackers
Dear Bertrand,

Thanks for updating the patch. I found one issue:

```
    /* DROP hook for the subscription being removed */
    InvokeObjectDropHook(SubscriptionRelationId, subid, 0);

```

I think the reporting should be after the loop, otherwise the wrong subid can be
reported. Am I missing something?

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Warn when io_min_workers exceeds io_max_workers
Next
From: shveta malik
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications