RE: Session in aborted transaction misses effective_wal_level change - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Session in aborted transaction misses effective_wal_level change
Date
Msg-id OS7PR01MB18317F5892929AECAF46CE01AF5952@OS7PR01MB18317.jpnprd01.prod.outlook.com
Whole thread
In response to Re: Session in aborted transaction misses effective_wal_level change  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Session in aborted transaction misses effective_wal_level change
List pgsql-hackers
Dear Sawada-san,

> Thank you for the comments. I'm now convinced that we can call it
> after resetting the top-level XID. I was concerned about the
> inconsistency between the AtEOXact_LogicalCtl() calls in
> CommitTransaction() and CleanupTransaction(), but it's fine for them
> to differ, since we're holding interrupts in the former but not in the
> latter. Calling AtEOXact_LogicalCtl() after resetting the top-level
> XID would be more bullet-proof, so let's go with this approach.
> 
> I've attached the updated patch. Please review it.

Understood, LGTM.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: ERROR: too late to create a new PlaceHolderInfo
Next
From: Shubhra Jain
Date:
Subject: Re: Allow pg_read_all_stats to read replication origin status