Request a Demo
Home   >   mailing lists

RE: Fix apply worker crash when subscriber table has only a deferrable primary key - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Fix apply worker crash when subscriber table has only a deferrable primary key
Date
Msg-id OS7PR01MB183175A0C8C0710245FE1E135F5962@OS7PR01MB18317.jpnprd01.prod.outlook.com
Whole thread
In response to Re: Fix apply worker crash when subscriber table has only a deferrable primary key  (Nisha Moond <nisha.moond412@gmail.com>)
List pgsql-hackers
Tree view 
Hi Nisha,

> Thanks for pushing the patch.
> Here is the rebased v4 patch for the remaining issue in this thread.

Thanks for updating the patch!

While reading the patch again, I came up with another idea to use already-found
local index. I.e., move logicalrep_rel_mark_updatable() after the
FindLogicalRepLocalIndex() then refer entry->idxisreplident and entry->localindexoid.
It may change codes bit more but we can use the single source of truth.

How do you feel?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: WAL segment file descriptor leak on read errors can PANIC the server
Next
From: David Rowley
Date:
Subject: Re: tuplesort_putdatum() does not account for tuple memory