Request a Demo
Home   >   mailing lists

RE: Session in aborted transaction misses effective_wal_level change - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Session in aborted transaction misses effective_wal_level change
Date
Msg-id OS7PR01MB183171352C8034F7415A54CC5F58A2@OS7PR01MB18317.jpnprd01.prod.outlook.com
Whole thread
In response to Re: Session in aborted transaction misses effective_wal_level change  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Session in aborted transaction misses effective_wal_level change
List pgsql-hackers
Tree view 
Dear Sawada-san, Serigei,

Good catch, I have also been seeing and considering the test, but Sawada-san is faster.

> The fix looks good to me. We need to check and update XLogLogicalInfo
> in every place where we reset the top-level transaction id.
> 
> I've updated the patch with the regression tests. Please review it.

Confirmed the test fails on HEAD and pass after the patch.
There might be idea to put the function after the "nParallelCurrentXids = 0;"
even in the CommitTransaction() and PrepareTransaction(), which is same as
CleanupTransaction(). But any places are OK for me.

LGTM.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

pgsql-hackers by date:

Previous
From: Narayanan Venkateswaran
Date:
Subject: Re: postgres_fdw: Fix costing of remote sorts without remote estimates
Next
From: Nisha Moond
Date:
Subject: Re: Fix apply worker crash when subscriber table has only a deferrable primary key