RE: [PATCH] Add a check_hook for output_plugin_libraries - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: [PATCH] Add a check_hook for output_plugin_libraries
Date
Msg-id OS7PR01MB183170040F50570C06A6D1060F58B2@OS7PR01MB18317.jpnprd01.prod.outlook.com
Whole thread
In response to Re: [PATCH] Add a check_hook for output_plugin_libraries  (Jacob Champion <jacob.champion@enterprisedb.com>)
List pgsql-hackers
Dear Jacob,

Thanks for updating the patch. Mostly LGTM, one minor comment.

```
+                               elog(ERROR, "invalid output_plugin_libraries syntax after check_hook?");
```

Per my grep, it is rarely happen to put"?" at the end of elog() message.
Maybe it's OK to say:

invalid list syntax in parameter \"%s\"

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: Direct TOAST v2, faster, smaller and no migration needed
Next
From: shveta malik
Date:
Subject: Re: Temporary slot leak when creation fails in a subtransaction