RE: Confused comment about drop replica identity index - Mailing list pgsql-hackers

From wangw.fnst@fujitsu.com
Subject RE: Confused comment about drop replica identity index
Date
Msg-id OS3PR01MB6275A10D03572E27C4E2C9769E769@OS3PR01MB6275.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Confused comment about drop replica identity index  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Confused comment about drop replica identity index  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Dec 15, 2021 at 11:25AM, Michael Paquier wrote:
> Yeah, the comment is wrong.  If the index of a REPLICA_IDENTITY_INDEX is
> dropped, I recall that the behavior is the same as REPLICA_IDENTITY_NOTHING.

Thank you for your response.
I agreed that the comment is wrong.


> Not sure about the DROP INDEX page, but I'd be fine with mentioning that in the
> ALTER TABLE page in the paragraph related to REPLICA IDENTITY.  While on it, I
> would be tempted to switch this stuff to use a list of <variablelist> for all the option
> values.  That would be much easier to read.

Yeah, if we can add some details to pg-doc and code comments, I think it will
be more friendly to PG users and developers.

Regards,
Wang wei



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: A test for replay of regression tests
Next
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication