RE: Added schema level support for publication. - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: Added schema level support for publication.
Date
Msg-id OS0PR01MB61137D9AD59572CF9B1DDFD3FB079@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Added schema level support for publication.  (vignesh C <vignesh21@gmail.com>)
Responses Re: Added schema level support for publication.  (Greg Nancarrow <gregn4422@gmail.com>)
Re: Added schema level support for publication.  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Hi

I applied your V7* patch and complied it. The following warnings came out, please take a look.

>pg_publication.c:688:22: warning: ‘tables’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   funcctx->user_fctx = (void *) tables;
>   ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
>describe.c: In function ‘describePublications’:
>describe.c:6479:35: warning: ‘pubtype’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   else if (has_pubtype && pubtype == PUBTYPE_SCHEMA)

For the warning in pg_publication.c, maybe we can replace the following 'else if' with 'else'.
+        else if (publication->pubtype == PUBTYPE_SCHEMA)

For the warning in describe.c, initialization of 'pubtype' is needed.

Regards
Tang

pgsql-hackers by date:

Previous
From: "zhangjie2@fujitsu.com"
Date:
Subject: [Patch] change the default value of shared_buffers in postgresql.conf.sample
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench logging broken by time logic changes