RE: Remove "FROM" in "DELETE FROM" when using tab-completion - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: Remove "FROM" in "DELETE FROM" when using tab-completion
Date
Msg-id OS0PR01MB61130BE81FA60AF689309B8FFB549@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Remove "FROM" in "DELETE FROM" when using tab-completion  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Remove "FROM" in "DELETE FROM" when using tab-completion
List pgsql-hackers
On Monday, May 10, 2021 4:15 PM, Julien Rouhaud <rjuju123@gmail.com> wrote
>We should change all to DELETE FROM (apart from \help of course), and same for
>INSERT, change to INSERT INTO everywhere it makes sense.

Thanks for the reply. Your advice sounds reasonable to me.
So I tried to change all "DELETE" to "DELETE FROM" and "INSERT" to "INSERT INTO" in the attached patch except
the follow cases which I think is in accordance with what PG-Doc said.
 CREATE POLICY
 CREATE [ OR REPLACE ] RULE
 CREATE [ OR REPLACE ] TRIGGER
 ALTER DEFAULT PRIVILEGES

After applying the patch, the tap-tests for psql is passed.
Please be free to tell me anything insufficient you found in my fix. Thanks.

Regards,
Tang

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Inherited UPDATE/DELETE vs async execution
Next
From: Andrew Dunstan
Date:
Subject: Re: Why do we have perl and sed versions of Gen_dummy_probes?