Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring - Mailing list pgsql-hackers

From Lucas DRAESCHER
Subject Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring
Date
Msg-id MVJo_s9NkLXQ1QYpxH_bTSHPX81pV_6BTv8Tmgs0AlU13rdxnhxh-9EWQoNXPeAqJ7TwXqA-L1x7dZuaRnZDwkIrcE7X9nrTtJdTF6z32xk=@draescher.fr
Whole thread
In response to Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring  ("cca5507" <cca5507@qq.com>)
Responses Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring
List pgsql-hackers
Hi ChangAo,

Thanks for the review!

I've attached v2, which adds a shmem_cleanup callback to
IoMethodOps, registered in AioShmemInit().

Like you, I don't know which approach I prefer since the
new callback currently has only one implementor. If no
other IO method is expected to need cleanup, the simpler
v1 approach may be preferable. Happy to hear your thoughts.

I've also added this patch to the commitfest app:
https://commitfest.postgresql.org/patch/6617/

Regards,
Lucas.
Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: Track skipped tables during autovacuum and autoanalyze
Next
From: Alvaro Herrera
Date:
Subject: Re: Adding REPACK [concurrently]