[PATCH][BUG FIX] Uninitialized variable parsed - Mailing list pgsql-hackers

From Ranier Vilela
Subject [PATCH][BUG FIX] Uninitialized variable parsed
Date
Msg-id MN2PR18MB2927C646DF2B4F4830E4AE1EE3490@MN2PR18MB2927.namprd18.prod.outlook.com
Whole thread Raw
Responses Re: [PATCH][BUG FIX] Uninitialized variable parsed  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
Hi,
Typo mystake?
Memset only fill a pointer size, not the size of struct.

Best regards.
Ranier Vilela

--- \dll\postgresql-12.0\a\backend\access\rmgrdesc\xactdesc.c    Mon Sep 30 17:06:55 2019
+++ xactdesc.c    Fri Nov 22 13:40:13 2019
@@ -35,7 +35,7 @@
 {
     char       *data = ((char *) xlrec) + MinSizeOfXactCommit;

-    memset(parsed, 0, sizeof(*parsed));
+    memset(parsed, 0, sizeof(xl_xact_parsed_commit));

     parsed->xinfo = 0;            /* default, if no XLOG_XACT_HAS_INFO is
                                  * present */
@@ -130,7 +130,7 @@
 {
     char       *data = ((char *) xlrec) + MinSizeOfXactAbort;

-    memset(parsed, 0, sizeof(*parsed));
+    memset(parsed, 0, sizeof(xl_xact_parsed_commit));

     parsed->xinfo = 0;            /* default, if no XLOG_XACT_HAS_INFO is
                                  * present */

Attachment

pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: range_agg
Next
From: Pavel Stehule
Date:
Subject: Re: range_agg