Re: Typo for xl_running_xacts - Mailing list pgsql-hackers

From Japin Li
Subject Re: Typo for xl_running_xacts
Date
Msg-id MEYP282MB16697A83B3940E289763D5EDB6069@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Typo for xl_running_xacts  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 17 Nov 2022, at 08:06, Japin Li <japinli@hotmail.com> wrote:
>
>> I find some typo about xl_running_xacts in comments.
>> Attached a patch to fix those.
>
> Thanks, applied!
>
>> -     * might look that we could use xl_running_xact's ->xids information to
>> +     * might look that we could use xl_running_xacts->xids information to
>
> I'm not a native english speaker, but since xl_running_xacts refers to a name
> in this case and not an indication of plural possession, ending with a 's is
> correct even if it ends with an 's', so I instead changed this to
> "xl_running_xacts's".

Thanks,  I found other places use "xl_running_xacs'",
such as "xl_running_xacts' oldestRunningXid" in snapbuild.c.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Typo for xl_running_xacts
Next
From: Richard Guo
Date:
Subject: Re: Making Vars outer-join aware