Re: Fixing pgbench init overflow - Mailing list pgsql-hackers

From Japin Li
Subject Re: Fixing pgbench init overflow
Date
Msg-id ME3P282MB316684190982F54BDBD4FE90B69BA@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Fixing pgbench init overflow  (Chen Hao Hsu <johnhyvr@gmail.com>)
Responses Re: Fixing pgbench init overflow
List pgsql-hackers
On Sat, 23 Dec 2023 at 07:18, Chen Hao Hsu <johnhyvr@gmail.com> wrote:
> Hello,
>
> pgbench mixes int and int64 to initialize the tables.
> When a large enough scale factor is passed, initPopulateTable
> overflows leading to it never completing, ie.
>
> 2147400000 of 2200000000 tuples (97%) of
> pgbench_accounts done (elapsed 4038.83 s, remaining 98.93 s)
> -2147400000 of 2200000000 tuples (-97%) of
> pgbench_accounts done (elapsed 4038.97 s, remaining -8176.86 s)
>
>
> Attached is a patch that fixes this, pgbench -i -s 22000 works now.

I think only the following line can fix this.

+    int64            k;

Do not need to modify the type of `n`, right?

--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.



pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: Transaction timeout
Next
From: Li Japin
Date:
Subject: Re: Transaction timeout