On Tue, 19 Dec 2023 at 17:57, Ishaan Adarsh <ishaanad9@gmail.com> wrote:
> I've addressed the points you raised:
>
> 1. *Missing `<filename>` Tag:*
> I reviewed the "Create the Makefile" section, and it seems that <filename>
> tags are appropriately used for filenames. If there's a specific instance
> where you observed a missing tag, please provide more details, and I'll
> ensure it's addressed.
>
Thanks.
> 2. *Use `CREATE EXTENSION` in "extension--version.sql":*
> Considering that there's already a CREATE EXTENSION step in the quick
> start guide, I can include a note in the general documentation to explain
> the rationale without repeating it in the individual script. What do you
> think?
Agreed.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
