Re: Fix outdated comments for IndexInfo - Mailing list pgsql-hackers

From Japin Li
Subject Re: Fix outdated comments for IndexInfo
Date
Msg-id ME0P300MB0445D523EA4AB5B6C27B633DB6822@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Fix outdated comments for IndexInfo  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Hi, Peter and Richard

On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter@eisentraut.org> wrote:
> On 30.04.25 17:48, Japin Li wrote:
>> While working on [1], I found outdated comments in IndexInfo.
>> The attached patch corrects them.
>> [1]
>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>
> Maybe these per-column comments should be moved inline, similar to,
> for example, ResultRelInfo later in the file.  That would make
> maintaining them easier.

Thank you for the review.  The v2 patch set is attached.

v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.

-- 
Regrads,
Japin Li


Attachment

pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment
Next
From: Bruce Momjian
Date:
Subject: Re: Should shared_preload_libraries be loaded during binary upgrade?