Remove unnecessary static type qualifiers - Mailing list pgsql-hackers

From Japin Li
Subject Remove unnecessary static type qualifiers
Date
Msg-id ME0P300MB0445C44B2DEC2FC9CEFC23E1B6B52@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
Whole thread Raw
Responses Re: Remove unnecessary static type qualifiers
List pgsql-hackers
Hi, all

When I read the libpq source code, I found unnecessary static type qualifiers
in PQsetClientEncoding().

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 0258d9ace3c..300ddfffd55 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -7717,7 +7717,7 @@ int
 PQsetClientEncoding(PGconn *conn, const char *encoding)
 {
     char        qbuf[128];
-    static const char query[] = "set client_encoding to '%s'";
+    const char    query[] = "set client_encoding to '%s'";
     PGresult   *res;
     int            status;
 


-- 
Regrads,
Japin Li



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [PATCH] clarify palloc comment on quote_literal_cstr
Next
From: Ilia Evdokimov
Date:
Subject: Re: track generic and custom plans in pg_stat_statements