RE: [19] CREATE SUBSCRIPTION ... SERVER - Mailing list pgsql-hackers

From Shinoda, Noriyoshi (PSD Japan FSI)
Subject RE: [19] CREATE SUBSCRIPTION ... SERVER
Date
Msg-id LV8PR84MB3787135EBDBF7747A05731F3EE592@LV8PR84MB3787.NAMPRD84.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: [19] CREATE SUBSCRIPTION ... SERVER  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: [19] CREATE SUBSCRIPTION ... SERVER
List pgsql-hackers
Hi,
Thanks for developing this great feature.

> Committed two patches.
The commit of 0004 patch added the `fdwconnection` column to the pg_foreign_data_wrapper catalog. 
However, it seems the documentation is missing the definition for this column. The small patch attached adds the
informationfor this column to catalog.sgml. There might be a better phrasing for the description text.
 

Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Jeff Davis <pgsql@j-davis.com> 
Sent: Thursday, March 19, 2026 4:07 AM
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>; Masahiko Sawada <sawada.mshk@gmail.com>; Shlok Kyal
<shlok.kyal.oss@gmail.com>;Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; Joe Conway <mail@joeconway.com>;
pgsql-hackers@postgresql.org
Subject: Re: [19] CREATE SUBSCRIPTION ... SERVER

On Sat, 2026-03-14 at 15:55 -0700, Jeff Davis wrote:
> Attached series including patches to address Andres's and Amit's 
> comments, too.

Committed two patches.

New patch 0004: fixes missing dependencies from the FDW to the connection function. There's a related pre-existing
issuewith the dependency from the FDW to the handler function, which I will post as a separate backportable bugfix.
 

I'd still like to find a good way to add pg_dump tests. The only idea I have now is to build the test function into
corepostgres (without pg_proc entry), which might be worthwhile.
 

Regards,
    Jeff Davis


Attachment

pgsql-hackers by date:

Previous
From: Tender Wang
Date:
Subject: Re: Bug: var_is_nonnullable() gives wrong results for old/new in RETURNING
Next
From: Fujii Masao
Date:
Subject: Re: Truncate logs by max_log_size