RE: AIX support - Mailing list pgsql-hackers

Hi Tom,

Please find attached the patch (See: v3-0001-Add-AIX-support-for-Postgresql-using-meson-build-.patch)

You will have to apply your patch https://www.postgresql.org/message-id/attachment/189255/v1-0001-Decouple-our-alignment-assumptions-about-int64-an.patch and then git apply v3-0001-Add-AIX-support-for-Postgresql-using-meson-build-.patch and then follow the meson build instructions in the commit message.

Thank you for the push. We have updated our branch. And this patch is made after the update.

>Please, don't squash all of the changes under discussion into a single
>patch.  We aren't likely to commit it like that, and merging different
>topics into one patch just makes it harder to review everything.
>In this case, it'd have been much better if you kept my changes from
>https://urldefense.proofpoint.com/v2/url?u=https-3A__www.postgresql.org_message-2Did_1694571.1769736080-40sss.pgh.pa.us&d=DwIFAg&c=BSDicqBQBDjDI9RkVyTcHQ&r=f-oUQ8ByG1nZ71OI9p76qywCPh7mxzU69hBYnkP9Nis&m=dyY-gcWS2Xjotl8-Qex9QwI6MDbnbGcKvghelG6GrW7SVQL3kExDhCzFif0sWkTA&s=Nbdnq5St72HOehkkV5kU2jH_Ofyg6Z7tKt846xg-plg&e=
>separate from the rest, so that it'd be easier to compare your work
>to the previous version 0001-Support-for-AIX.pg19.v11.patch.

>Also, please pretty please use systematic naming including a version
>number for new patches.  It's far from obvious that
>0001-Add-AIX-support-for-Postgresql-using-meson-build-too.patch is
>newer than 0001-Support-for-AIX.pg19.v11.patch.  (If you're making
>the patch files with git format-patch, use "-v N".)

I have taken care of the same. Please see now and let me know.

Rest of the comments same as previous email comments.

Have a nice day.

Regards,

Aditya.