[BUGS] 答复: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border - Mailing list pgsql-bugs

From shao bret
Subject [BUGS] 答复: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border
Date
Msg-id HK2PR0201MB08821B28BCCAE567EEED23D0E6000@HK2PR0201MB0882.apcprd02.prod.outlook.com
Whole thread Raw
In response to [BUGS] Re: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs

 

Please help to see the patch file.

Thanks.

Bret

 

发送自 Windows 10 邮件应用

 

发件人: Michael Paquier
发送时间: 2017411 11:05
收件人: shao bret
抄送: PostgreSQL mailing lists; Andres Freund
主题: Re: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border

 

On Mon, Apr 10, 2017 at 4:02 PM, shao bret <bret.shao@outlook.com> wrote:
> I think maybe you have a little misunderstanding with my solution.

Without a proper patch it is hard to have a clear opinion in this case.

> My solution is that
> [...]
> So I think it
s easier for understanding code.
>
> What do you think?

One way or the other would be fine, at the end the last call will
likely come from Andres in CC as he is the author and committer of
replication origins. To be honest, I find the use of mul_size()
cleaner here, but that's just an opinion.
--
Michael

 

Attachment

pgsql-bugs by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: [BUGS] Issues
Next
From: constantinos.eleftheriou@ed.ac.uk
Date:
Subject: [BUGS] BUG #14620: pgdg93 repo libevent conflict