Re: Code coverage report generation for JS files - Mailing list pgadmin-hackers
Hi Aditya,
As per your feedback, pleas find updates as below:
1) Remove commented code. Done
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
- Updated package.json for : "test:karma-coverage" & "test:karma-coverage-once"
3) Add the new coverage directory to .gitignore. Done
Have attached patch with email.
Thanks you !
From: Dave Page <dpage@pgadmin.org>
Date: Thursday, 6 August 2020 at 6:18 PM
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pramod Ahire <pramod.ahire@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hmm, this makes me think - if we have enough of the JS infrastructure on the SonarQube scanner server (which is easy to create in the Jenkins job), we could import the lcov reports into SonarQube.
On Thu, Aug 6, 2020 at 1:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Attachment
pgadmin-hackers by date: