> -----Original Message-----
> From: Jean-Michel POURE [mailto:jm.poure@freesurf.fr]
> Sent: 22 February 2002 22:11
> To: Dave Page; pgadmin-hackers@postgresql.org
> Subject: Re: ALTER VIEW
>
>
> Le Vendredi 22 Février 2002 23:06, Dave Page a écrit :
>
> > 5) The modifications to the SQL property are messy & mainly
> > unnecessary (certainly with #1 above - that just needs bDrop &
> > szViewName).
> Will have a look at it tomorrow. I though interesting to
> write SQL using a
> single property. This is easier to maintain code. Don't flame me...
I'm not flaming you :-) That code took hundreds of hours for me to write,
and I just want to keep it how I think is right. I'm liable to be
overprotective for a while :-)
My problem with your code, is not how you chose to write it - you are
correct, a single SQL function is easier to maintain, but:
- Some of what you wrote is not yet required and for simplicity shouldn't be
there - szViewDefinition/Comment
- With the create/rename approach, all that is required is the option to
drop and an alternate name.
These functions are also APIs available to the non-pgAdmin programmer. I
want to keep them as clean and intuitive as possible.
One other thing I noticed (while I'm flaming you :-p ) can you use 2 char
tabs to match the rest of the code please.
Cheers, Dave.
