Re: Microoptimization of Bitmapset usage in postgres_fdw - Mailing list pgsql-hackers

Thanks for the updated patch set.

On 6/14/18, 2:34 PM, "Daniel Gustafsson" <daniel@yesql.se> wrote:
>> 2) BuildRelationExtStatistics() in extended_stats.c.
>> 
>>     /* check allowed number of dimensions */
>>     Assert(bms_num_members(stat->columns) >= 2 &&
>>            bms_num_members(stat->columns) <= STATS_MAX_DIMENSIONS);
>
> Since this usage is in an assertion I don’t see the value in changing it as the
> current programming is more optimized for readability.

Agreed.  I hesitated to even point this one out.

I'll go ahead and mark this as Ready for Committer.

Nathan