Re: Use XLOG_CONTROL_FILE macro everywhere? - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Use XLOG_CONTROL_FILE macro everywhere?
Date
Msg-id FC257A2E-D989-46DC-8232-AB14C3D7A0B2@yesql.se
Whole thread Raw
In response to Re: Use XLOG_CONTROL_FILE macro everywhere?  ("Anton A. Melnikov" <a.melnikov@postgrespro.ru>)
Responses Re: Use XLOG_CONTROL_FILE macro everywhere?
List pgsql-hackers
> On 24 Apr 2024, at 11:13, Anton A. Melnikov <a.melnikov@postgrespro.ru> wrote:
>
> On 24.04.2024 12:02, Peter Eisentraut wrote:
>> On 19.04.24 05:50, Anton A. Melnikov wrote:
>>>
>>> May be better use this macro everywhere in C code?
>> I don't know.  I don't find XLOG_CONTROL_FILE to be a very intuitive proxy for "pg_control".

Maybe, but inconsistent usage is also unintuitive.

> Then maybe replace XLOG_CONTROL_FILE with PG_CONTROL_FILE?
>
> The PG_CONTROL_FILE_SIZE macro is already in the code.
> With the best regards,

XLOG_CONTROL_FILE is close to two decades old so there might be extensions
using it (though the risk might be slim), perhaps using offering it as as well
as backwards-compatability is warranted should we introduce a new name?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Re: Fix parallel vacuum buffer usage reporting
Next
From: "Anton A. Melnikov"
Date:
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?