Re: Rename of varatt_external to varatt_external_oid - Mailing list pgsql-hackers

From Chao Li
Subject Re: Rename of varatt_external to varatt_external_oid
Date
Msg-id FBE0E804-F1F5-4AD5-8A46-445F26B097A7@gmail.com
Whole thread
In response to Re: Rename of varatt_external to varatt_external_oid  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

> On Sep 4, 2026, at 09:20, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Sep 04, 2026 at 08:43:37AM +0800, Chao Li wrote:
>> I tried to review this patch, but “git am” failed on the current
>> HEAD (2b3d11aaed8). Would you please rebase?
>
> Oops.  Sorry for the incorrect rebase blurp caused by 2b3d11aaed89.
> The attached should work better.
> --
> Michael
> <v2-0001-Rename-varatt_external-to-varatt_external_oid.patch>

I briefly went through the referenced patch as well as Tom’s comment, so I have no objection to this renaming.

The code changes in v2 look good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Ayush Tiwari
Date:
Subject: Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl
Next
From: Henri GASC
Date:
Subject: Re: [SQL/PGQ] Native executor for Graph query