Re: Fix GROUP BY ALL handling of ORDER BY operator semantics - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix GROUP BY ALL handling of ORDER BY operator semantics
Date
Msg-id F8D8CB8C-5628-4557-A694-1484D5A44340@yesql.se
Whole thread
Responses Re: Fix GROUP BY ALL handling of ORDER BY operator semantics
List pgsql-hackers
> On 14 Jul 2026, at 18:08, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:

>> Shouldn't those two queries yield the same result, or am I missing something
>> obvious?
>
> I might be undercaffeinated still, but I think those are both correct.

I think you are right, I confused myself on the cases where group by all is
rewritten into group by ().

FWIW, I had a look at what a revert of the commit would look like.  The
original commit included some while-in-there docs/comment cleanups which carry
value on their own, so I think we should leave those in.  The attached reverts
GROUP BY ALL but retains the cleanups.  If we decide to revert, the v19 back
patch would need to remove the entry from the release notes as well, but I only
did a master revert patch for now.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Global temporary tables
Next
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Cover get_json_table_plan() with tests