17 июля 2018 г., в 16:42, Nikita Glukhov <n.gluhov@postgrespro.ru> написал(а):
>
> Fixed.
Patch works as advertised, adds documentation and tests. I didn't succeeded in attempts to break it's functionality. I
haveno more notices about the code.
Maybe except this const looks unusual, but is correct
+extern BOX *box_copy(const BOX *box);
I'm not sure in architectural point of view: supporting two ways (list and heap) to store result seems may be a bit
heavy,but OK. At least, it has meaningful benefits.
I think the patch is ready for committer.
Best regards, Andrey Borodin.
