Re: pg_stat_progress_cluster: do not default to CLUSTER - Mailing list pgsql-hackers

From Chao Li
Subject Re: pg_stat_progress_cluster: do not default to CLUSTER
Date
Msg-id F3F89D60-1FCB-4195-86C6-91B1A05BF6CF@gmail.com
Whole thread
In response to Re: pg_stat_progress_cluster: do not default to CLUSTER  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers

> On Sep 9, 2026, at 14:55, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Sep 9, 2026 at 1:03 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> So, repack_index_relid now describes the actual scan method but not if index ordering was requested. Maybe we should
setPROGRESS_REPACK_INDEX_RELID in cluster_rel() rather than heapam_relation_copy_for_cluster()? Like in the attache
diff.
>
> Thanks for the patch! LGTM.
>
>> it will translate any REPACK command into one of these other two.
>
> If we apply the proposed patch, at the same moment, personally I'd like to
> update this description of pg_stat_progress_cluster.command in the docs
> so that it clearly explains how REPACK is translated. How about:
>
>    it will translate a REPACK command into CLUSTER if index ordering
> is requested,
>    or VACUUM FULL otherwise.

Yes, that makes sense. I added integrated your suggestion into the patch.

PFA v2:

* 0001 - unchanged from v1-0001
* 0002 - the previous diff plus integrating Fujii-san suggested doc change

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/





Attachment

pgsql-hackers by date:

Previous
From: "yangboyu"
Date:
Subject: 回复:logical decoding: skip unnecessary snapshot distribution.
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD