Re: Fix incorrect function comment of stringToNodeInternal - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix incorrect function comment of stringToNodeInternal
Date
Msg-id ED8E9601-E342-4DAA-B6BD-38C70BDDC290@yesql.se
Whole thread Raw
In response to Fix incorrect function comment of stringToNodeInternal  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Fix incorrect function comment of stringToNodeInternal
List pgsql-hackers
> On 23 Sep 2025, at 09:50, Chao Li <li.evan.chao@gmail.com> wrote:

> Again, found an incorrect function comment of stringToNodeInternal(). Wrong function name is put to the comment, I
guessit was from a copy/paste error. 

I think this is intentional, and the proposed change would not improve it.  The
comment refers to the externally visible symbols stringToNodeWithLocations
(when enabled) and stringToNode The stringToNodeInternal function is just an
implementation detail of it, hence the comment further down on the actual
stringToNode() function being "Externally visible entry points".

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Add support for specifying tables in pg_createsubscriber.
Next
From: Michael Paquier
Date:
Subject: Re: Incorrect logic in XLogNeedsFlush()