Re: Add "format" target to make and ninja to run pgindent and pgperltidy - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Date
Msg-id EAB73E05-6551-4537-A742-C091C9206B25@yesql.se
Whole thread Raw
In response to Re: Add "format" target to make and ninja to run pgindent and pgperltidy  (Jelte Fennema-Nio <postgres@jeltef.nl>)
List pgsql-hackers
> On 13 Mar 2026, at 16:11, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> On Fri, 13 Mar 2026 at 11:03, Daniel Gustafsson <daniel@yesql.se> wrote:
>> The primary reason thus far has been that pgperltidy requires a specific
>> version of perltidy, no other version is accepted.  Imposing the burden of
>> installing that on a greater subset of people than a subset of committers
>> didn't seem palatable.
>
> I think that makes sense if the burden is big, but with patch 0008 it
> becomes as simple as running a single command:
> src/tools/pgindent/get_perltidy

In todays world of supply-chain attacks, don't think it's all that palatable to
take responsibility for installing code in peoples environments.  Regardless, I
don't think the patch should remove the installation instructions.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [PATCH] Silence a new Valgrind warning
Next
From: Tomas Vondra
Date:
Subject: Re: gistGetFakeLSN() can return incorrect LSNs