Re: [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators - Mailing list pgsql-hackers

From Chengpeng Yan
Subject Re: [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators
Date
Msg-id E9205C03-C8F8-4835-BC31-24499ECE724F@outlook.com
Whole thread
In response to Re: [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
> On Apr 23, 2026, at 13:32, David Rowley <dgrowleyml@gmail.com> wrote:
>
> I thought of it, but didn't do it as it meant having to keep a bit
> more state to track if we've filled the cache yet, plus the extra
> costs incurred to check if we've done it yet that would have to be
> paid for every NULL lookup. We currently have to check if the hash
> table has been set up already, so I felt more comfortable installing
> the new code in with that.


That makes sense to me. I agree that tying it to the existing hash-table
setup is the simpler place to do it, and avoids adding extra state plus
another check on each NULL lookup.

So I am fine with keeping it as-is.
--
Best regards,
Chengpeng Yan



pgsql-hackers by date:

Previous
From: 南拓弥
Date:
Subject: Re: Warn on missing replica identity in CREATE/ALTER PUBLICATION
Next
From: shveta malik
Date:
Subject: Re: Parallel Apply