Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id E918F3EB-7706-4657-AC13-95CF05131298@yandex-team.ru
Whole thread
In response to Re: GIN pageinspect support for entry tree and posting tree  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers

> On 3 Aug 2026, at 17:40, Kirill Reshke <reshkekirill@gmail.com> wrote:
> 
> Hi all,
> 
> I have rebased patches and did little polishing for error
> messages/overall style. Posting to see how new CI reacts & also bump
> thread.
> 
Hi Kirill,

The CF entry is still Ready for Committer, but Japin's August 13 review
found that gin_entrypage_items() does not finalize its temporary tuple
descriptor before index_getattr(). With assertions enabled, the new
check added by c456e391138 can fail here.

Could you fold the proposed TupleDescFinalize() call into a new patch
version? I have moved the entry to Waiting on Author for now.

Thank you!


Best regards, Andrey Borodin.



pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: CREATE TABLE LIKE INCLUDING TRIGGERS
Next
From: Andrey Borodin
Date:
Subject: Commitfest manager for September 2026