Re: Rev 4704 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Rev 4704
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E4E7DE8A@ratbert.vale-housing.co.uk
Whole thread Raw
In response to Rev 4704  (Andreas Pflug <pgadmin@pse-consulting.de>)
Responses Re: Rev 4704
List pgadmin-hackers

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 09 November 2005 10:20
> To: Dave Page; pgadmin-hackers
> Subject: Rev 4704
>
> Dave,
>
> I'm trying to make sense of your change of ShowTipOfTheDay's
> type from
> bool to int for 1.5. The type was changed to bool in 1.3, and I don't
> see a reason to change it again.

As we discussed last week, it causes an assert in debug builds on
Windows as wx seems to be unable to cast from DWORD to bool. Even
deleting the registry key and allowing it to recreate it itself doesn't
help.

This was the only fix that seemed to make sense without the pain of
fixing wx. Note that other true/false registry keys are stored as
true/false strings - I didn't change to follow that convention as it
would definitely not be backwards compatible with existing DWORD values.

/D


pgadmin-hackers by date:

Previous
From: svn@pgadmin.org
Date:
Subject: SVN Commit by andreas: r4708 - branches/REL-1_4_0_PATCHES/pgadmin3
Next
From: "Dave Page"
Date:
Subject: Re: SVN Commit by andreas: r4705 - branches/REL-1_4_0_PATCHES/pgadmin3