Thanks, patch applied!
Regards, Dave.
> -----Original Message-----
> From: Jeremy Palmer [mailto:palmerj@xtra.co.nz]
> Sent: 15 June 2006 13:20
> To: Dave Page; pgadmin-support@postgresql.org
> Subject: RE: [pgadmin-support] init script for redhat
>
> Ok, thanks for the tips. I have attached an updated patch.
>
> Cheers
> Jeremy
>
> > -----Original Message-----
> > From: Dave Page [mailto:dpage@vale-housing.co.uk]
> > Sent: Friday, 16 June 2006 12:09 a.m.
> > To: Jeremy Palmer; pgadmin-support@postgresql.org
> > Subject: RE: [pgadmin-support] init script for redhat
> >
> >
> >
> > > -----Original Message-----
> > > From: Jeremy Palmer [mailto:palmerj@xtra.co.nz]
> > > Sent: 15 June 2006 12:59
> > > To: Dave Page; pgadmin-support@postgresql.org
> > > Subject: RE: [pgadmin-support] init script for redhat
> > >
> > > Hi Dave,
> > >
> > > Attached is a patch that allows pgagent to immediately log
> > > messages to file.
> > > I have tentatively changed the cmd line switch for logging
> > > verbosity to "-s"
> > > so "-l" can be used for the log file specification. I felt
> > > that this was
> > > more intuitive.
> > >
> > > If the patch is accepted, then a small change to the init
> > > script will need
> > > to be made to accommodate the file logging...
> >
> > Hi Jeremy,
> >
> > Looks good - just a couple of points...
> >
> > - Strings that are candidates for translation (when added
> to pgAgent)
> > should be wrapped in the _() macro, not wxT(); for example,
> your 'cannot
> > open the logfile' string.
> >
> > - Changing the command line options is unnacceptable except
> in extreme
> > cases because it can easily confuse people when upgrading,
> expecially if
> > they miss the change. Please use -l for the loglevel as per current
> > releases and choose another letter for the logfile.
> >
> > Thanks, Dave.
>
