> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 03 April 2006 16:06
> To: Dave Page
> Cc: pgadmin-hackers
> Subject: Re: [pgadmin-hackers] Query grid
>
> If the current implementation isn't rewritten, I'll commit a virtual
> rewrite of wxListView based ctlSqlResult (as soon as I find the time,
> which will certainly not be this week). It will probably require more
> work on frmQuery (remove the ctl filling loop, no need for the second
> timing display) than on the ctl itself, making it incompatible to
> ctlSqlResult implementations that are not managing their data
> virtually.
Yeah, well hold fire on that - I just found what broke it, and now get
(second of 2 runs in each version, from the same server):
1.5.0:
-- Executing query:
select * from pbx_log limit 10000
Total query runtime: 8187 ms.
Data retrieval runtime: 1062 ms.
10000 rows retrieved.
1.4.1:
-- Executing query:
select * from pbx_log limit 10000
Total query runtime: 8187 ms.
Data retrieval runtime: 9125 ms.
10000 rows retrieved.
I was killing that query after a few minutes in 1.5.0 until I found the
bug (introduced here:
http://svn.pgadmin.org/cgi-bin/viewcvs.cgi?rev=5068&view=rev).
I'll find a netter way of solving that issue and commit the appropriate
fixes.
Now I don't think you can deny that with or without a virtual table,
that definitely works better than the listview does - and that was
tested on Mac and *nix. If you can improve it further then feel free,
but please do not break the new copy 'n' paste capabilities.
Regards, Dave
