Re: Odbcapi30.c - 64 bit compiler warning cleanup - Mailing list pgsql-odbc

From Dave Page
Subject Re: Odbcapi30.c - 64 bit compiler warning cleanup
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E40103DB7F@ratbert.vale-housing.co.uk
Whole thread Raw
In response to Odbcapi30.c - 64 bit compiler warning cleanup  ("Dave Page" <dpage@vale-housing.co.uk>)
Responses Re: Odbcapi30.c - 64 bit compiler warning cleanup  (Ludek Finstrle <luf@pzkagis.cz>)
List pgsql-odbc

> -----Original Message-----
> From: Ludek Finstrle [mailto:luf@pzkagis.cz]
> Sent: 27 January 2006 08:26
> To: Dave Page
> Cc: Tom Lane; pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] Odbcapi30.c - 64 bit compiler warning cleanup
>
> > > > The spec actually says it should be a SQLPOINTER.
> Changing to that
> > > > unleashes a whole barrel of extra fun unfortunately.
> > >
> > > I don't think it will be so problematic. I'll try it.
> It's the best way
> > > to support Win64.
> >
> > Here is my result. Patch attached. I have no 64-bit box
> ready at hand here.
> > I will test it on 64-bit box tomorrow.
>
> I find one problem. New patch attached. I get no warning with
> this one.
>
> Please review and comment

Looks good on 64 bit linux and Windows here.

BTW, in your version bump commit, you missed a bit in psqlodbc.rc:

 FILEVERSION 8,1,1,8
 PRODUCTVERSION 8,1,1,8

I've committed this, but just in case you weren't aware :-)

/D

pgsql-odbc by date:

Previous
From: Ludek Finstrle
Date:
Subject: Re: Odbcapi30.c - 64 bit compiler warning cleanup
Next
From: Antoine
Date:
Subject: network saturation