Re: PATCH: CITEXT 2.0 v3 - Mailing list pgsql-hackers

From David E. Wheeler
Subject Re: PATCH: CITEXT 2.0 v3
Date
Msg-id E778558F-21CA-4E58-BF94-215448DB09E3@kineticode.com
Whole thread Raw
In response to Re: PATCH: CITEXT 2.0 v3  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Jul 14, 2008, at 10:55, Andrew Dunstan wrote:

> No.
>
> --no-locale is the same as --locale=C which means the encoding is
> SQL_ASCII.

I've used --no-locale --encoding UTF-8 many times. But if the
regressions run with SQL_ASCII…well, I'm just amazed that there
haven't been more unexpected side-effects to source code changes
without controlling for such variables in tests. Seems like a lot to
keep in one's head.

Anyway, are tests for contrib modules run on the build farms? If so, I
could still potentially get around this issue by turning off ECHO.

Best,

David



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: PATCH: CITEXT 2.0 v3
Next
From: Tom Lane
Date:
Subject: Re: PATCH: CITEXT 2.0 v3