pgsql: oauth_validator: Remove racing GUC check - Mailing list pgsql-committers

From Jacob Champion
Subject pgsql: oauth_validator: Remove racing GUC check
Date
Msg-id E1xEsRi-00000000qLk-0WHw@gemulon.postgresql.org
Whole thread
List pgsql-committers
oauth_validator: Remove racing GUC check

Follow-up to bca67e5a3. The test added there changed the value of
oauth_validator_libraries, waited for the postmaster to apply it, and
verified the change on an existing background connection. But there's no
guarantee that the SIGHUP will have arrived and completed its work on
existing backends by that time, so the final test flaked.

We only care about the postmaster's state here, since we're testing the
GUC's effects on newly forked backends, so remove the background check
entirely.

Per buildfarm member serinus.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/a37a3cea-5bd8-4385-a1d4-bb89394c079c%40gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f1eafd911ddde87f84672b5bf227a3e6cae6331f

Modified Files
--------------
src/test/modules/oauth_validator/t/001_server.pl | 2 --
1 file changed, 2 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: COPY TO FORMAT JSON: use the query's column names as keys
Next
From: Robert Haas
Date:
Subject: pgsql: Add child_append_relid_sets to ElidedNode; use in pg_plan_advice