pgsql: Fix failure of setrefs.c to process child_append_relid_sets - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Fix failure of setrefs.c to process child_append_relid_sets
Date
Msg-id E1xEqvJ-00000000pk3-1q4P@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix failure of setrefs.c to process child_append_relid_sets

Commit 7358abcc6076f4b2530d10126ab379f8aea612a5 taught the planner to
store information about Append node consolidation in the final plan,
but it forgot that child_append_relid_sets needs to be adjusted
at setrefs.c time just like every other place where we store RTIs
in a plan tree. Fix that.

Although this can cause incorrect plan advice to be emitted in cases
involving multi-level partitioning, it seems more appropriate to put
the test case for it in pg_overexplain, so this commit does that.

Backpatch-through: 19
Discussion: http://postgr.es/m/CA+TgmoYYHC4i-Gpzc9-JYHqih6pOK+6LTYFiNR-PioXG1nKkOQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0f7dfd7936b9e99f9aeca00f52ab1692898ffff4

Modified Files
--------------
contrib/pg_overexplain/expected/pg_overexplain.out | 75 ++++++++++++++++++++++
contrib/pg_overexplain/sql/pg_overexplain.sql      | 23 +++++++
src/backend/optimizer/plan/setrefs.c               | 23 +++++++
3 files changed, 121 insertions(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Optimize tuple deformation
Next
From: Robert Haas
Date:
Subject: pgsql: pg_plan_advice: Avoid miscategorizing partitionwise scans as ord