pgsql: Skip isolation tests that terminate other backends on Windows - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Skip isolation tests that terminate other backends on Windows
Date
Msg-id E1xDYBo-00000000LNg-19i3@gemulon.postgresql.org
Whole thread
List pgsql-committers
Skip isolation tests that terminate other backends on Windows

On Windows, a backend exiting resets its connection, and the client
discards any data not yet read, including the FATAL message of a
terminated backend.  isolationtester polls one connection at a time, so
when it waits on a different session the message can get lost, failing
the permutation and the tests that run after it.

wait_cleanup in injection_points (down to v17) and slot_creation_error
in test_decoding (down to v15) have this pattern, and have been failing
randomly in the buildfarm.  Let's skip them on Windows.

The cause of the instabilities is proving to be tricky to deal with,
pointing for example at 29992a6a509b.  This will be tackled later,
perhaps with a backpatch (or perhaps with a HEAD-only solution), but it
is difficult to be sure at this stage of the work.  In theory,
a8458f508a7 should make a revert of 29992a6a509b (revert of a revert!)
safe on WIN32.

Note that 278cdea6b9d2, that has introduced the isolation test
slot_creation_error in test_decoding, has mentioned the potential output
instability.

Author: Zsolt Parragi <zsolt.parragi@percona.com>
Author: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CAN4CZFOoiKa9E4Gnh_OzLk3S5Z6RFyg_oY1e_WddCVYhkpTVow@mail.gmail.com
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e0f633ca6bc6a2ace3e6c0e79157c3bf0edddfbe

Modified Files
--------------
contrib/test_decoding/Makefile                |  8 ++++-
contrib/test_decoding/meson.build             | 40 +++++++++++++----------
src/test/modules/injection_points/Makefile    |  7 +++-
src/test/modules/injection_points/meson.build | 46 ++++++++++++++++-----------
4 files changed, 64 insertions(+), 37 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Use tuplestore_clear instead of tuplestore_end in nodeMaterial.c
Next
From: David Rowley
Date:
Subject: pgsql: Use tuplestore_clear instead of tuplestore_end in nodeTableFuncs